[core] Do not use path.toUri().toString() when a location string is expected internally

[Zouxxyy]

Purpose

path.toUri() converts a path into a standardized URI string (e.g., file:/tmp/path/test file → file:/tmp/path/test%20file), with special characters encoded (like spaces → %20).

we should avoid use new Path(p1.toUri().toString()), see this test

String location = "file:/tmp/path/test file";
String encodedLocation = "file:/tmp/path/test%20file";
Path p1 = new Path(location);
assertThat(p1.toString()).isEqualTo(location);
assertThat(p1.toUri().toString()).isEqualTo(encodedLocation);

// Using p1.toString() to create a new Path is correct
Path p2 = new Path(p1.toString());
assertThat(p2.toString()).isEqualTo(location);
assertThat(p2.toUri().toString()).isEqualTo(encodedLocation);

// Using p1.toUri().toString to create a new Path will encode again
Path p3 = new Path(p1.toUri().toString());
assertThat(p3.toString()).isEqualTo(encodedLocation);
assertThat(p3.toUri().toString()).isEqualTo("file:/tmp/path/test%2520file");

Tests

API and Format

Documentation

[JingsongLi]

+1