[python] Support conflict detection when updating existing data concurrently.#7323
Merged
JingsongLi merged 10 commits intoapache:masterfrom Mar 3, 2026
Merged
[python] Support conflict detection when updating existing data concurrently.#7323JingsongLi merged 10 commits intoapache:masterfrom
JingsongLi merged 10 commits intoapache:masterfrom
Conversation
JingsongLi
reviewed
Mar 3, 2026
| partition: Tuple | ||
| bucket: int | ||
| new_files: List[DataFileMeta] | ||
| snapshot_for_update: int = -1 |
Contributor
There was a problem hiding this comment.
just check_from_snapshot? and use Option[long]
Contributor
Author
There was a problem hiding this comment.
I will rename it.
JingsongLi
reviewed
Mar 3, 2026
| # Extract snapshot_for_update from commit messages | ||
| for msg in commit_messages: | ||
| if msg.snapshot_for_update != -1: | ||
| self.conflict_detection._row_id_check_from_snapshot = msg.snapshot_for_update |
Contributor
There was a problem hiding this comment.
Here should do a min computation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Support conflict detection when updating the data-evolution table concurrently.
Tests
API and Format
Documentation
Generative AI tooling