Draft
Conversation
5ce27f8 to
a59205f
Compare
3d68a64 to
541f746
Compare
c288568 to
1a5cd6f
Compare
4f54e5d to
186ed45
Compare
a0f9a9b to
d6b1fd1
Compare
7a9cd62 to
b57993e
Compare
JingsongLi
reviewed
Mar 5, 2026
|
|
||
| <dependency> | ||
| <groupId>org.apache.paimon</groupId> | ||
| <artifactId>paimon-lumina-jni</artifactId> |
Contributor
There was a problem hiding this comment.
com.aliyun.lumina
lumina-jni
JingsongLi
reviewed
Mar 5, 2026
| import scala.collection.JavaConverters._ | ||
|
|
||
| /** End-to-end tests for Lumina vector index read/write operations on Spark 3.5. */ | ||
| class LuminaVectorIndexE2ETest extends PaimonSparkTestBase { |
Contributor
There was a problem hiding this comment.
Just move these tests to spark-ut?
JingsongLi
reviewed
Mar 5, 2026
| <version>1.4-SNAPSHOT</version> | ||
| </parent> | ||
|
|
||
| <artifactId>paimon-lumina</artifactId> |
Contributor
There was a problem hiding this comment.
Just one paimon-lumina is OK, no need to have index and e2e.
JingsongLi
reviewed
Mar 5, 2026
| <version>1.4-SNAPSHOT</version> | ||
| </parent> | ||
|
|
||
| <artifactId>paimon-lumina</artifactId> |
Contributor
There was a problem hiding this comment.
Please create a README.md to this, explain what is lumina.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #xxx
Tests
API and Format
Documentation
Generative AI tooling