Skip to content

[python] Support REST function API in pypaimon#7559

Merged
JingsongLi merged 1 commit intoapache:masterfrom
XiaoHongbo-Hope:support_function
Apr 2, 2026
Merged

[python] Support REST function API in pypaimon#7559
JingsongLi merged 1 commit intoapache:masterfrom
XiaoHongbo-Hope:support_function

Conversation

@XiaoHongbo-Hope
Copy link
Copy Markdown
Contributor

@XiaoHongbo-Hope XiaoHongbo-Hope commented Mar 30, 2026

Purpose

Tests

rest_function_test run with mock server and real rest server both. And bug or gap is fixed in #7575 and #7568

@JingsongLi
Copy link
Copy Markdown
Contributor

@XiaoHongbo-Hope
Copy link
Copy Markdown
Contributor Author

@XiaoHongbo-Hope XiaoHongbo-Hope force-pushed the support_function branch 2 times, most recently from 747de10 to 379d5b9 Compare April 1, 2026 13:49
@XiaoHongbo-Hope XiaoHongbo-Hope marked this pull request as ready for review April 2, 2026 03:43
@XiaoHongbo-Hope
Copy link
Copy Markdown
Contributor Author

Take a look to https://github.com/unitycatalog/unitycatalog/blob/main/ai/core/src/unitycatalog/ai/core/client.py#L875

Do you mean we can support callable function in Pypaimon? We can create a separate PR for it.

@gavin9402
Copy link
Copy Markdown
Contributor

+1


uuid: Optional[str] = json_field(FIELD_UUID, default=None)
name: Optional[str] = json_field(FIELD_NAME, default=None)
input_params: Optional[List] = json_field(FIELD_INPUT_PARAMS, default=None)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a List[dict] or List[DataField]?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a List[dict] or List[DataField]?

Update it as List[DataField]

Comment thread paimon-python/pypaimon/api/rest_api.py Outdated
return database_name.strip(), table_name.strip()


class IllegalArgumentError(Exception):
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be defined in catalog_exception.py.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be defined in catalog_exception.py.

Moved

return self._type == other._type and self._data == other._data

def __hash__(self):
return hash(self._type)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not add _data?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not add _data?

Refactored and followed same structure with java.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi JingsongLi merged commit 5427a95 into apache:master Apr 2, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants