[python] Add file_source assertion in row-tracking commit to fail fast on missing file_source#7610
Merged
JingsongLi merged 1 commit intoapache:masterfrom Apr 9, 2026
Merged
Conversation
…t on missing file_source
Contributor
|
+1 |
yuzelin
pushed a commit
that referenced
this pull request
Apr 12, 2026
…t on missing file_source (#7610) if file_source is None, the condition `None == 0` silently evaluates to False, skipping row ID assignment. This causes nextRowId not to increment, leading to first_row_id conflicts. So this PR add file_source check like java.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
if file_source is None, the condition
None == 0silently evaluates to False, skipping row ID assignment. This causes nextRowId not to increment, leading to first_row_id conflicts. So this PR add file_source check like java.Tests