[core] Fix FieldListaggAgg distinct mode incorrectly skipping values …#7652
Merged
Conversation
…due to substring matching
XiaoHongbo-Hope
added a commit
that referenced
this pull request
Apr 19, 2026
XiaoHongbo-Hope
pushed a commit
that referenced
this pull request
Apr 19, 2026
…7652) Fix a bug in `FieldListaggAgg.agg()` where the distinct deduplication logic incorrectly uses substring matching (`BinaryString.contains()`) instead of exact token matching, causing valid values to be silently dropped. For example, with delimiter `,`: - accumulator = `"abc,def,asd"` - inputField = `"ab,xy"` - Token `"ab"` is incorrectly skipped because `"abc,def,asd".contains("ab")` returns `true` - Result: `"abc,def,asd,xy"` (missing `"ab"`) - Expected: `"abc,def,asd,ab,xy"`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix a bug in
FieldListaggAgg.agg()where the distinct deduplication logicincorrectly uses substring matching (
BinaryString.contains()) instead ofexact token matching, causing valid values to be silently dropped.
For example, with delimiter
,:"abc,def,asd""ab,xy""ab"is incorrectly skipped because"abc,def,asd".contains("ab")returns
true"abc,def,asd,xy"(missing"ab")"abc,def,asd,ab,xy"Tests
testFieldListAggDistinctShouldNotMatchSubstring
testFieldListAggDistinctSubstringWithCustomDelimiter