[jindo] Extract doDelete() template method from HadoopCompliantFileIO#7668
Merged
JingsongLi merged 1 commit intoapache:masterfrom Apr 20, 2026
Merged
Conversation
Refactor delete() to delegate to a protected doDelete() method. Subclasses can override delete() with custom logic and call doDelete() when they need the real filesystem delete.
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Refactor
HadoopCompliantFileIO.delete()to delegate to a newprotected doDelete(Path, boolean)template method. This allows subclasses (e.g. JindoFileIO) to intercept delete operations (trash/recycle-bin, audit logging, etc.) while retaining access to the real filesystem delete viadoDelete().Changes
protected doDelete(Path, boolean)delete()now delegates todoDelete()— no behavior change for existing codedelete()with custom logic and calldoDelete()for the actual deleteTests
API and Format
No API or storage format changes.
Documentation
No documentation changes needed.