[iceberg] Fix NPE in IcebergRestMetadataCommitter when table has no snapshots#7688
Merged
Merged
Conversation
…napshots currentSnapshot() can return null for tables that exist but have no snapshots yet. The log statement in commitMetadataImpl did not handle this case, causing a NullPointerException.
Contributor
|
+1 Thanks @JTaky |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When committing Iceberg metadata via the REST catalog,
commitMetadataImpltakes the!withBasecode path if the base metadata check fails.In this path, a log statement calls
currentSnapshot().snapshotId()on both the existing and new table metadata. However,currentSnapshot()returns null when a table exists but has no snapshots (e.g., a freshly created or empty table), causing aNullPointerExceptionthat fails the entire commit. Since it happens only for an empty iceberg table, we can manually delete the table and be unblocked.Meanwhile we should not have NPE in the log method.
Implementation
Added null guards for
metadata.currentSnapshot()andnewMetadata.currentSnapshot()in the log statement, logging"No snapshot"when the snapshot is absent.