[core] Support BlobRef in internal blob serializer#7689
Closed
leaves12138 wants to merge 5 commits into
Closed
Conversation
leaves12138
changed the title
JingsongLi
reviewed
Apr 24, 2026
Contributor
JingsongLi
left a comment
JingsongLi
left a comment
There was a problem hiding this comment.
Why not using isBlobDescriptor to deserialize BlobDescriptor?
Contributor
Author
Reasonable |
Contributor
Author
|
Don't fix this until we meet it in reality |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
BlobSerializer and internal binary writers previously called
blob.toData()unconditionally. For BlobRef this forces loading the full blob payload, which defeats the lazy reference semantics and can be prohibitively expensive.Tests