[iceberg] Fix compaction commits emitting 'overwrite' instead of 'replace' in Iceberg snapshot operation#7702
Merged
JingsongLi merged 1 commit intoapache:masterfrom Apr 27, 2026
Conversation
…lace' in Iceberg snapshot operation
Contributor
Author
|
@JingsongLi @plusplusjiajia Please have a look at this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7683.
When Paimon compacts an LSM table with the Iceberg metadata committer enabled, the resulting Iceberg snapshot has its
operationfield set to"overwrite". According to the Iceberg spec, compaction and file rewrite operations should use"replace"instead. Using"overwrite"makes downstream consumers like Polaris REST catalogs and query engines think the compaction was a data mutation, which is incorrect.The problem was in
IcebergCommitCallback.createWithDeleteManifestFileMetas(), which hardcodedIcebergSnapshotSummary.OVERWRITEwhenever files were removed, without checking whether the commit was actually a compaction.The fix:
IcebergSnapshotSummary.REPLACEconstant for the"replace"operationSnapshot.CommitKindintocreateWithDeleteManifestFileMetas()and useREPLACEwhencommitKind == COMPACT,OVERWRITEotherwiseIcebergCompatibilityTest.testDeleteImpl()to verify that compaction commits produceoperation: "replace"in the Iceberg snapshot metadata