[core] Check next snapshot's time for snapshotTimeRetain expiration protection#7706
Merged
Conversation
…rotection Previously, a snapshot was expired if its own timestamp exceeded snapshotTimeRetain. This could cause premature expiration when snapshotRetainMin is small. Now we check the next snapshot's timestamp instead, ensuring each snapshot is protected for the full snapshotTimeRetain duration.
JingsongLi
force-pushed
the
expire_protect
branch
from
dd7dff4 to
6c63480
Compare
JingsongLi
changed the title
JingsongLi
changed the title
tsreaper
reviewed
May 8, 2026
…apshotsTest.java Co-authored-by: tsreaper <tsreaper96@gmail.com>
tsreaper
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Previously, a snapshot was expired if its own timestamp exceeded snapshotTimeRetain. This could cause premature expiration when snapshotRetainMin is small. Now we check the next snapshot's timestamp instead, ensuring each snapshot is protected for the full snapshotTimeRetain duration.
Tests
ExpireSnapshotsTest.java