[flink][spark] fix incorrect first_row_id range in DataEvolution MergeInto#7790
Merged
Merged
Conversation
steFaiz
force-pushed
the
fix_de_merge_into_row_id
branch
from
3641cbd to
e0f3ba7
Compare
Contributor
|
Thanks @steFaiz +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Current first row id check in DataEvolutionPartialWriter maybe incorrect because of special files i.e. Blob Files and Vector FIles, which may cause:
This is because the blob file's record count override the normal file's record count:
We should filter out special files when calculating first_row_id to record_count mapping
Tests
See :
org.apache.paimon.flink.action.DataEvolutionMergeIntoActionITCasefor flink testorg.apache.paimon.spark.sql.BlobTestBasefor spark test