[core] fix NPE in BTreeFileMetaSelector when btree index contains empty string key.#7812
Open
zhoulii wants to merge 3 commits into
Open
[core] fix NPE in BTreeFileMetaSelector when btree index contains empty string key.#7812zhoulii wants to merge 3 commits into
zhoulii wants to merge 3 commits into
Conversation
steFaiz
reviewed
May 11, 2026
| sliceOutput.writeInt(lastKey.length); | ||
| sliceOutput.writeBytes(lastKey); | ||
| } else { | ||
| sliceOutput.writeInt(0); |
Contributor
There was a problem hiding this comment.
Dose this have incompatibility risks? For example if an old version file is all-null, a new version meta will set the firstKey and lastKey as an empty byte[].
Member
Author
There was a problem hiding this comment.
Good catch! You're right — there is a backward compatibility risk. When an old-version file has all-null keys (serialized as int(0) for both keys), the new deserializer would incorrectly read them as byte[0] instead of null. Fixed already.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
close #7811
Tests