[core] Coalesce concurrent CachingCatalog table loads#7840
Merged
JingsongLi merged 1 commit intoMay 13, 2026
Merged
Conversation
leaves12138
approved these changes
May 13, 2026
Contributor
leaves12138
left a comment
leaves12138
left a comment
There was a problem hiding this comment.
LGTM. The approach looks right: using Caffeine's atomic Cache.get(key, mappingFunction) coalesces concurrent misses per table identifier while preserving the existing system-table behavior (only the origin table is cached). Wrapping/unwrapping TableNotExistException keeps the public API semantics unchanged, and the added concurrent test covers the intended race.
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #7484.
CachingCatalog#getTablenow uses Caffeine's atomic cache loading path for regular tables, so concurrent cache misses for the same identifier share onewrapped.getTablecall. System tables continue to wrap the cached origin table instead of being cached directly.Tests
mvn -pl paimon-core -Pfast-build -Dtest=CachingCatalogTest#testConcurrentGetTableLoadsTableOnce testmvn -pl paimon-core -Pfast-build -Dtest=CachingCatalogTest testmvn -pl paimon-core spotless:check