Skip to content

[codex] Support replacing index manifest in overwrite commit#7855

Merged
leaves12138 merged 1 commit into
apache:masterfrom
leaves12138:codex/replace-index-manifest-overwrite
May 14, 2026
Merged

[codex] Support replacing index manifest in overwrite commit#7855
leaves12138 merged 1 commit into
apache:masterfrom
leaves12138:codex/replace-index-manifest-overwrite

Conversation

@leaves12138
Copy link
Copy Markdown
Contributor

@leaves12138 leaves12138 commented May 14, 2026

Purpose

Allow overwrite-style commits that already replace manifest lists to also provide an explicit index manifest and next row id.

The existing replaceManifestList behavior stays compatible, while a same-name overload lets metadata rewrite workflows preserve or replace snapshot-level index metadata and row-id state explicitly.

Changes

  • Add a replaceManifestList overload that accepts indexManifest and nextRowId.
  • Keep the existing replaceManifestList signature by delegating to the overload with the latest snapshot values.

Verification

  • mvn -pl paimon-core -DskipTests compile

@leaves12138 leaves12138 force-pushed the codex/replace-index-manifest-overwrite branch from 0bb0e82 to 043e752 Compare May 14, 2026 10:29
@leaves12138 leaves12138 marked this pull request as ready for review May 14, 2026 10:30
Copy link
Copy Markdown
Contributor

@yuzelin yuzelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@leaves12138 leaves12138 merged commit 603ad85 into apache:master May 14, 2026
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants