[core] Reduce file store scan for overwriting if new changes doesn't touch the target partitions#7894
Merged
Merged
Conversation
added 4 commits
May 19, 2026 10:56
…touch the target partitions
tsreaper
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
We have manifest cache now, but through test, the cache can reduce read file time, but the more time is spent on decode file content. And in test case, the user commit interval is 30s, readOverwriteChanges will use 60s - 80s.
Since the overwrite partitions are rarely to be changed, I think cache the manifest entries is a good idea.
Tests