-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[spark] Introduce plan-auto-tag-for-read for Spark read #7897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
105 changes: 105 additions & 0 deletions
105
paimon-core/src/main/java/org/apache/paimon/tag/BatchReadTagCreator.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,105 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.paimon.tag; | ||
|
|
||
| import org.apache.paimon.Snapshot; | ||
| import org.apache.paimon.utils.SnapshotManager; | ||
| import org.apache.paimon.utils.TagManager; | ||
|
|
||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| import javax.annotation.Nullable; | ||
|
|
||
| import java.time.Duration; | ||
| import java.util.Collections; | ||
| import java.util.UUID; | ||
|
|
||
| /** Creates temporary tags to protect snapshots from expiration during batch reads. */ | ||
| public class BatchReadTagCreator { | ||
|
|
||
| private static final Logger LOG = LoggerFactory.getLogger(BatchReadTagCreator.class); | ||
|
|
||
| public static final String BATCH_READ_TAG_PREFIX = "batch-read-"; | ||
|
|
||
| private final TagManager tagManager; | ||
| private final SnapshotManager snapshotManager; | ||
| private final Duration timeRetained; | ||
|
|
||
| public BatchReadTagCreator( | ||
| TagManager tagManager, SnapshotManager snapshotManager, Duration timeRetained) { | ||
| this.tagManager = tagManager; | ||
| this.snapshotManager = snapshotManager; | ||
| this.timeRetained = timeRetained; | ||
| } | ||
|
|
||
| @Nullable | ||
| public String createReadTag(long snapshotId) { | ||
| Snapshot snapshot; | ||
| try { | ||
| snapshot = snapshotManager.snapshot(snapshotId); | ||
| } catch (Exception e) { | ||
| LOG.warn("Failed to get snapshot {} for read protection tag.", snapshotId, e); | ||
| return null; | ||
| } | ||
|
|
||
| String tagName = generateTagName(snapshotId); | ||
| try { | ||
| tagManager.createTag(snapshot, tagName, timeRetained, Collections.emptyList(), true); | ||
| LOG.info( | ||
| "Created batch read protection tag '{}' for snapshot {}.", tagName, snapshotId); | ||
| return tagName; | ||
| } catch (Exception e) { | ||
| LOG.warn( | ||
| "Failed to create batch read protection tag for snapshot {}. " | ||
| + "Read will proceed without protection.", | ||
| snapshotId, | ||
| e); | ||
| return null; | ||
| } | ||
| } | ||
|
|
||
| public void deleteReadTag(String tagName) { | ||
| try { | ||
| if (tagManager.tagExists(tagName)) { | ||
| // Directly delete the tag metadata file instead of using TagManager.deleteTag(), | ||
| // which would also scan and delete unreferenced data files — too heavyweight for a | ||
| // read-path cleanup. Any orphan data files left behind will be reclaimed by | ||
| // OrphanFilesClean. | ||
| snapshotManager.fileIO().deleteQuietly(tagManager.tagPath(tagName)); | ||
| LOG.info("Deleted batch read protection tag '{}'.", tagName); | ||
| } | ||
| } catch (Exception e) { | ||
| LOG.warn( | ||
| "Failed to delete batch read protection tag '{}'. " | ||
| + "It will be cleaned up by TTL expiration.", | ||
| tagName, | ||
| e); | ||
| } | ||
| } | ||
|
|
||
| public static boolean isBatchReadTag(String tagName) { | ||
| return tagName.startsWith(BATCH_READ_TAG_PREFIX); | ||
| } | ||
|
|
||
| private String generateTagName(long snapshotId) { | ||
| String uuid = UUID.randomUUID().toString().substring(0, 8); | ||
| return BATCH_READ_TAG_PREFIX + snapshotId + "-" + uuid; | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intentionally deleting only the tag meta file instead of calling table.deleteTag(tagName) to
keep read cleanup lightweight
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Directly delete the tag metadata file instead of using TagManager.deleteTag(), which would also scan and delete unreferenced data files — too heavyweight for a read-path cleanup. Any orphan data files left behind will be reclaimed by OrphanFilesClean.
Commented in 1d4a461
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it.