[core] Minor refactor partition predicates in FallbackReadScan#7950
Merged
JingsongLi merged 2 commits intoMay 27, 2026
Conversation
This was referenced May 25, 2026
JingsongLi
reviewed
May 25, 2026
| scan.withPartitionFilter(scanPartitionPredicate); | ||
| if (isMain && getMainPartitionPredicate() != null) { | ||
| scan.withPartitionFilter(getMainPartitionPredicate()); | ||
| } else if (getFallbackPartitionPredicate() != null) { |
Contributor
There was a problem hiding this comment.
No !isMain &&? Please add test for this.
Contributor
Author
There was a problem hiding this comment.
Thanks a lot for your review. The testMainAndFallbackPartitionPredicates has already been added.
juntaozhang
force-pushed
the
pr-refactor-FallbackReadScan
branch
from
398e99c to
fdfc312
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR is a prerequisite for
[spark] Support compact_chain_table procedure.FallbackReadScancurrently uses a singlepartitionPredicatefor both main and fallback scans. However, in chain table compaction scenarios, we need to apply differentpartition filters to the main (snapshot) branch and the fallback (delta) branch. For example, when overwriting an existing partition, we need to:
This PR refactors
FallbackReadScanto support separate partition predicates for main and fallback scans.Tests
FallbackReadFileStoreTableTest.testMainAndFallbackPartitionPredicates