[python] Fix Daft fallback filter limit pushdown#7965
Merged
Conversation
Contributor
|
Looks good to me with little comment. |
e583140 to
408da42
Compare
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The Daft Paimon datasource used the configured read builder for scan planning, but fallback split tasks rebuilt a bare
TableRead. As a result, fallback reads for PK merge, non-Parquet formats, BLOB columns, and deletion-vector paths could miss pushed predicate/projection/limit state.This was correctness-sensitive because Daft may treat pushed filters as already handled by the source. A query filtering a fallback table could plan the right split but still emit unfiltered rows from that split. There was also a related limit-ordering issue: applying
limitinside the fallback reader while Daft still had remaining row or partition filters could truncate rows before those filters were evaluated.This patch makes fallback tasks use a configured
TableRead, keeps the required filter columns available for fallback execution, and centralizes the source-side limit decision solimitis only pushed when it is safe for the source to apply it before returning rows.Tests