[python][daft] Fix predicate conversion for unsupported expressions#7980
Merged
JingsongLi merged 1 commit intoMay 27, 2026
Merged
Conversation
JingsongLi
approved these changes
May 27, 2026
Contributor
JingsongLi
left a comment
There was a problem hiding this comment.
LGTM. This is a well-designed safety fix. The core insight is correct: using None as a sentinel for both "unsupported expression" and "literal value" was a type confusion that could silently push incorrect predicates and remove them from Daft's remaining filter list — changing query semantics.
The _Literal / _Unsupported marker approach is clean and makes the type distinction explicit throughout the visitor. The _is_pushable_scalar guard also correctly rejects None literals and collection types from pushdown.
Test coverage for the mixed-expression scenarios is good.
+1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Daft predicate conversion used
Noneto represent both unsupported expressions and literal values. As a result, comparison pushdown could treat unsupported expressions as literals, for example converting a cast expression intoid = None.String predicates also called
str(...)on visited arguments, so column or unsupported arguments could be pushed as literal strings. This could mark filters as pushed and remove them from Daft remaining filters, changing query semantics.This patch adds explicit internal markers for literals and unsupported expressions. Predicates are only pushed when the non-column side is a real scalar literal, and string predicates now require real string literals. Unsupported or mixed expressions stay in Daft remaining filters.
Tests
python -m pytest paimon-python/pypaimon/tests/daft/daft_data_test.py -k 'FilterPushdown'python -m pytest paimon-python/pypaimon/tests/daft/daft_data_test.py