Skip to content

[core] support adding blob column through comments#7996

Merged
JingsongLi merged 6 commits into
apache:masterfrom
steFaiz:add_blob_by_comments
May 29, 2026
Merged

[core] support adding blob column through comments#7996
JingsongLi merged 6 commits into
apache:masterfrom
steFaiz:add_blob_by_comments

Conversation

@steFaiz
Copy link
Copy Markdown
Contributor

@steFaiz steFaiz commented May 27, 2026

Purpose

This PR is about to replace #7921

This PR introduces a comment format to mark an adding column as BlobType. So that these engines which do not have BlobType can also add blob columns.
The rule is:

  1. define 2 directives: __BLOB_FIELD, __BLOB_DESCRIPTOR_FIELD
  2. user comments are seperated by ;: e.g. __BLOB_FIELD; this is a blob field, The starting directives will be trimmed.
  3. blob-field and blob-descriptor-field are immutable, and will be atomically modified during Alter Table Add Column and Drop Column.

NOTE:

  1. we do not permit updating any existing non-blob fields to blob type nor updating any blob field to non-blob type.
  2. we do not permit adding an blobType field without directives, since we don't know how to store them.

Tests

ITCases and UnitTests

Copy link
Copy Markdown
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi JingsongLi merged commit 46b120d into apache:master May 29, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants