[python][daft] Make Daft Paimon write sink serializable#8022
Merged
JingsongLi merged 1 commit intoMay 29, 2026
Conversation
leaves12138
approved these changes
May 29, 2026
Contributor
leaves12138
left a comment
There was a problem hiding this comment.
LGTM.
I reviewed the pickle/reconstruction path for PaimonDataSink. The state now avoids carrying the table/FileIO objects, reconstructs the table from catalog options + identifier (or table path fallback), and preserves the commit user / overwrite mode when rebuilding the write builder. The changed files compile and the PR checks are green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
PaimonDataSinkcurrently keeps theFileStoreTableandWriteBuilderdirectly in the sink object. When Daft runs with the Ray runner, the sink needs to be serialized and sent to workers. For OSS/Jindo tables, the table can indirectly hold PyArrow/Jindo filesystem objects that are not picklable, causing Ray serialization failures.This PR makes the Daft Paimon write sink serializable by only storing reconstructable table state during pickling.
Tests
CI