[python][daft] Preserve pushed filters across source serialization#8061
Merged
Conversation
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
PaimonDataSource.__setstate__()restores pushed filter state before reopening the table, but_init_table()then reset_pushed_filters,_paimon_predicate, and_remaining_filterstoNone.This made serialized Daft sources lose filters already accepted by
push_filters(). In fallback reads,get_tasks(Pushdowns(filters=None, limit=1))could then plan an unfiltered limited read and return the wrong row.This PR moves pushdown state initialization to
__init__(), keeps_init_table()limited to table-derived metadata, and includes_pushed_filtersin the serialized state for consistent explain/debug output.Tests
pytest paimon-python/pypaimon/tests/daft/daft_data_test.py