[core] Improve BTree global index option handling#8137
Merged
Conversation
leaves12138
force-pushed
the
btree-records-per-range-10m
branch
from
e8d58f5 to
34e99ff
Compare
leaves12138
changed the title
Contributor
|
I reviewed this PR as part of a pass over recent open non-draft Paimon PRs. I did not find any clear correctness, compatibility, or regression issue to flag from the current diff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR improves BTree global index option handling for both the default write path and manual global-index creation procedures.
Changes
btree-index.records-per-rangefrom1,000,000to10,000,000to reduce the number of BTree global index files generated by default.CreateGlobalIndexProcedureinitialize user options fromtable.options()and let parsed procedure options override table options.CreateGlobalIndexProcedureuse the same table-option inheritance and procedure-option override behavior.Tests
mvn -pl paimon-common -am -Pfast-build -DfailIfNoTests=false -Dtest=BTreeIndexOptionsTest testmvn -pl paimon-spark/paimon-spark-common -am -Pfast-build -DfailIfNoTests=false -Dtest=CreateGlobalIndexProcedureTest#testCreateUserOptionsUsesTableOptionsAndParsedOptionsOverride testmvn -pl paimon-flink/paimon-flink-common -am -Pfast-build -DfailIfNoTests=false -Dtest=CreateGlobalIndexProcedureTest#testCreateUserOptionsUsesTableOptionsAndParsedOptionsOverride testNote
A broader Spotless/Checkstyle run was blocked locally by snapshot dependency resolution for
paimon-test-utils:1.5-20260605.010817-72.