You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This changes the non-distinct LISTAGG behavior when the accumulator is null. For the first non-blank value, mergeFieldSD is initialized as BinaryString.EMPTY_UTF8, and the final path returns concat(EMPTY, delimiter, input), so the result starts with the delimiter (for example ",first line"). This breaks the existing Flink ListAggAggregationITCase. Could we keep the old accumulator == null handling for non-blank inputs, and add a test for agg(null, BinaryString.fromString("first line"))?
This changes the non-distinct LISTAGG behavior when the accumulator is null. For the first non-blank value, mergeFieldSD is initialized as BinaryString.EMPTY_UTF8, and the final path returns concat(EMPTY, delimiter, input), so the result starts with the delimiter (for example ",first line"). This breaks the existing Flink ListAggAggregationITCase. Could we keep the old accumulator == null handling for non-blank inputs, and add a test for agg(null, BinaryString.fromString("first line"))?
Thanks for pointing this out! I've adjusted it accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
[Fix] Ignore blank input values when using field.{fieldName}.aggregate-function=listagg
Expected behavior
'user1,user2,user3'''(empty string)'user1,user2,user3,'❌'user1,user2,user3''user1,user2,user3'' '(space)'user1,user2,user3, '❌'user1,user2,user3''user1,user2,user3''\t'(tab)'user1,user2,user3,\t'❌'user1,user2,user3''user1,user2,user3''\n'(newline)'user1,user2,user3,\n'❌'user1,user2,user3''user1,user2,user3''\r'(carriage return)'user1,user2,user3,\r'❌'user1,user2,user3'' '(whitespace only)'user1,user2,user3'' ,user1,user2,user3'❌'user1,user2,user3'Blank values are determined using
org.apache.paimon.utils.StringUtils.StringUtils.isBlank(...).Tests