This repository was archived by the owner on May 10, 2024. It is now read-only.
PARQUET-636: Expose selection for different encodings #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| bool dictionary_enabled_; | ||
| int64_t dictionary_pagesize_; | ||
| Encoding::type default_encoding_; | ||
| std::unordered_map<std::string, Encoding::type> encodings_; |
Member
There was a problem hiding this comment.
Can you add a comment explaining this member variable?
Contributor
There was a problem hiding this comment.
Or perhaps refactor these pairs of variables into instances of PerColumnProperties<Encoding::type/Compression::type> to avoid duplicating comments.
Member
|
Looks good outside minor comment. We can spare implementing the Parquet 2.0 encodings for now. |
Member
|
+1, will merge on green build |
Member
Author
|
Build is green ;) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet we still only support PLAIN encoding. Will implement the other encodings in separate PRs to not have huge changesets.