-
Notifications
You must be signed in to change notification settings - Fork 189
PARQUET-428: Support INT96 and FIXED_LEN_BYTE_ARRAY types #27
Conversation
|
The first check passed on Travis CI https://travis-ci.org/apache/parquet-cpp/builds/105457807 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about dictionary encoding (see the BYTE_ARRAY specialization there)? It's hard to verify that it works without tests, though, we should try to address that soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will add that now. Actually its rare for these types to be dictionary encoded.
I tested this on my side and it seems to work okay. We should definitely add tests after PARQUET-435
|
Can you create |
|
The macro STRUCT_END(Int96, 12) includes a static assert. I checked that this works locally. |
|
Ah good point, thanks. I think it's fine to omit the test, then. We should eventually move |
|
Is this one good to go? |
|
Rebased and good to go from my side. |
|
I am using java hadoop and parquet library. My parquet schema is: And my value is of type BigDecimal. And I am writing to parquet file as follows: I am getting exception: Any ideas how to resolve it? |
|
You're in the wrong place -- this is the original repo for the Parquet C++ project |
This PR adds support for INT96 and FIXED_LEN_BYTE_ARRAY types.
It modifies the examples and DebugPrint to handle these types.