This repository was archived by the owner on May 10, 2024. It is now read-only.
PARQUET-501: Add OutputStream abstract interface, refactor encoding code paths#46
Closed
wesm wants to merge 1 commit intoapache:masterfrom
Closed
PARQUET-501: Add OutputStream abstract interface, refactor encoding code paths#46wesm wants to merge 1 commit intoapache:masterfrom
wesm wants to merge 1 commit intoapache:masterfrom
Conversation
|
This will be some conflict with #30. |
| const vector<T>& right) { | ||
| ASSERT_EQ(left.size(), right.size()); | ||
|
|
||
| for (size_t i = 0; i < left.size(); ++i) { |
Member
Author
There was a problem hiding this comment.
It prints i on assertion failure
Member
Author
|
I squashed these commits to simplify cherry-picking because #47 depends on this patch. |
…ream implementation for testing. * Refactor to use OutputStream on data encoding paths, reduce some code duplication in column-reader-test. * Collect all input/output classes into util/input.* and util/output.*. * Use int64_t in InputStream::Peek/Read.
Member
Author
|
Rebased. @asandryh and @majetideepak let me know any other comments |
Member
|
+1 LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also did a bit of tidying / reorganization and giving interfaces more descriptive names.