This repository was archived by the owner on May 10, 2024. It is now read-only.
PARQUET-518: Remove -Wno-sign-compare and scrub integer signedness#63
Closed
wesm wants to merge 3 commits intoapache:masterfrom
Closed
PARQUET-518: Remove -Wno-sign-compare and scrub integer signedness#63wesm wants to merge 3 commits intoapache:masterfrom
wesm wants to merge 3 commits intoapache:masterfrom
Conversation
Member
Author
|
I'll rebase and complete this after #64 is merged |
Member
Author
|
@majetideepak if you could review, thank you! |
| const std::vector<int16_t>& def_levels, int16_t max_def_level, | ||
| const std::vector<int16_t>& rep_levels, int16_t max_rep_level) { | ||
| size_t num_values = values.size(); | ||
| int num_values = values.size(); |
Member
Author
There was a problem hiding this comment.
It is okay to cast to int unless there is concern about an overflow -- data pages are limited to INT32_MAX anyway
|
+1 LGTM |
Member
Author
|
Rebased |
Member
Author
|
Travis CI appears to be having problem again this morning, I just pinged them about it |
Member
Author
Member
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch removes compiler warning suppresses, fixes signed-unsigned integer comparisons, and scrubs most usages of
size_tfrom the codebase in favor of signed integer types.