This repository was archived by the owner on May 10, 2024. It is now read-only.
PARQUET-520: Add MemoryMapSource and add unit tests for both it and LocalFileSource#66
Closed
wesm wants to merge 4 commits intoapache:masterfrom
Closed
PARQUET-520: Add MemoryMapSource and add unit tests for both it and LocalFileSource#66wesm wants to merge 4 commits intoapache:masterfrom
wesm wants to merge 4 commits intoapache:masterfrom
Conversation
Member
Author
|
|
||
| ASSERT_THROW(this->source.Seek(this->filesize_ + 1), ParquetException); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
We should also test Read() functionality. See an example in #56.
…mory-map flag to parquet_reader
Member
Author
|
All set. let me know any more comments, thank you! |
Contributor
|
+1 LGTM. |
Member
Author
Member
|
+1 |
Member
Author
|
thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also added the
file_descriptorAPI so that we can verify that dtors elsewhere successfully close open files. Closes #56