PARQUET-564: Add cmake option to run valgrind on each unit test executable

[wesm]

This also enables the current test suite to pass cleanly under ctest with this option enabled.

[wesm]

cc @xhochy @asandryh for review

[xhochy]

This does not work on Linux as it will override all previously set target properties and thus compiling will fail due to the wrong tr1/tuple handling. The following line worked for me and seems to be the common way to append to target properties (note the explicit space between " and -D):

SET_PROPERTY(TARGET ${TEST_NAME} APPEND_STRING PROPERTY COMPILE_FLAGS " -DPARQUET_VALGRIND")

[wesm]

Cool, thank you, will remember this for the future

[wesm]

@xhochy can you take a look and let me know if this looks good?

I tried using ${MEMORYCHECK_COMMAND} but it does not report leaks as errors (--error-exitcode), so I left the explicit valgrind call as is.

[xhochy]

Looking good! ${MEMORYCHECK_COMMAND} just evaluates to /usr/bin/valgrind for me. As it is a very unlikely case that someone wants to use a valgrind installation that is not in PATH, we probably should not care about ${MEMORYCHECK_COMMAND}.

[wesm]

thank you.