Skip to content
This repository was archived by the owner on May 10, 2024. It is now read-only.

PARQUET-568: Enable top-level column selection.#81

Closed
asandryh wants to merge 2 commits intoapache:masterfrom
asandryh:PARQUET-568
Closed

PARQUET-568: Enable top-level column selection.#81
asandryh wants to merge 2 commits intoapache:masterfrom
asandryh:PARQUET-568

Conversation

@asandryh
Copy link
Contributor

No description provided.

@asandryh
Copy link
Contributor Author

@wesm Can you review this patch? Thanks.

@wesm
Copy link
Member

wesm commented Mar 22, 2016

Can you modify the JIRA to reflect this this is limited only to the DebugPrint method? I'll review the code now but I don't believe we should be continuing to invest energy in this method vs. a more versatile "ParquetFilePrinter"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO(asandryh) here?

@wesm
Copy link
Member

wesm commented Mar 22, 2016

This is OK to facilitate further debugging, but we need to be able to test this code's correctness if we continue any further down this path.

@asandryh
Copy link
Contributor Author

@wesm Thank you for the comments, I've incorporated them into the PR and update the JIRA.
You're correct, this functionality is primarily to facilitate debugging. It will also be useful after DebugPrint is factored out of ParquetFileReader in PARQUET-508.

@wesm
Copy link
Member

wesm commented Mar 23, 2016

+1, thank you

@asfgit asfgit closed this in 486aa10 Mar 23, 2016
@asandryh asandryh deleted the PARQUET-568 branch March 23, 2016 15:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments