Skip to content
This repository was archived by the owner on May 10, 2024. It is now read-only.

PARQUET-582: Conversions functions for Parquet enums to Thrift enums #86

Closed
xhochy wants to merge 2 commits into from
Closed

PARQUET-582: Conversions functions for Parquet enums to Thrift enums #86

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a742f6
PARQUET-582: Conversions functions for Parquet enums to Thrift enums
xhochy Apr 16, 2016
4fe3cf6
Add DCHECK
xhochy Apr 17, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions src/parquet/thrift/util.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,28 @@ static inline Compression::type FromThrift(format::CompressionCodec::type type)
return static_cast<Compression::type>(type);
}

static inline format::Type::type ToThrift(Type::type type) {
return static_cast<format::Type::type>(type);
}

static inline format::ConvertedType::type ToThrift(LogicalType::type type) {
// item 0 is NONE
Copy link
Copy Markdown
Member

@wesm wesm Apr 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a DCHECK_NE(type, LogicalType::NONE)

Copy link
Copy Markdown
Member Author

@xhochy xhochy Apr 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

DCHECK_NE(type, LogicalType::NONE);
return static_cast<format::ConvertedType::type>(static_cast<int>(type) - 1);
}

static inline format::FieldRepetitionType::type ToThrift(Repetition::type type) {
return static_cast<format::FieldRepetitionType::type>(type);
}

static inline format::Encoding::type ToThrift(Encoding::type type) {
return static_cast<format::Encoding::type>(type);
}

static inline format::CompressionCodec::type ToThrift(Compression::type type) {
return static_cast<format::CompressionCodec::type>(type);
}

// ----------------------------------------------------------------------
// Thrift struct serialization / deserialization utilities

Expand Down