Uniformizing booleans naming in ParquetWriter#1041
Closed
hamza-tam wants to merge 2 commits into
Closed
Conversation
yabola
suggested changes
Apr 5, 2023
Contributor
|
Yeah, public ones are tricky and we need to make it compatible. But overall, this is a great effort to improve our code. |
Contributor
|
Unfortunately, we cannot change public static methods, since other projects might be using them. If we want this we first need to deprecate the old values. |
Contributor
|
Closing this since we have to go through the deprecation cycle which seems a bit excessive for just a rename |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Jira
Tests
Commits
Documentation