Skip to content

Uniformizing booleans naming in ParquetWriter#1041

Closed
hamza-tam wants to merge 2 commits into
apache:masterfrom
hamza-tam:clean-up/fix-boolean-naming-inconsistency
Closed

Uniformizing booleans naming in ParquetWriter#1041
hamza-tam wants to merge 2 commits into
apache:masterfrom
hamza-tam:clean-up/fix-boolean-naming-inconsistency

Conversation

@hamza-tam
Copy link
Copy Markdown

Make sure you have checked all steps below.

Jira

Tests

  • My PR does not need testing for this extremely good reason: Only variable renaming

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

yabola
yabola approved these changes Apr 5, 2023
Copy link
Copy Markdown
Contributor

@yabola yabola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on it. Overall looks well. it can help to unify the code style.

But you modified the public variable, which may lead to code forward incompatibility. This may be unacceptable

@shangxinli
Copy link
Copy Markdown
Contributor

Yeah, public ones are tricky and we need to make it compatible. But overall, this is a great effort to improve our code.

@Fokko
Copy link
Copy Markdown
Contributor

Fokko commented Oct 17, 2023

Unfortunately, we cannot change public static methods, since other projects might be using them. If we want this we first need to deprecate the old values.

@Fokko
Copy link
Copy Markdown
Contributor

Fokko commented May 5, 2026

Closing this since we have to go through the deprecation cycle which seems a bit excessive for just a rename

@Fokko Fokko closed this May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants