GH-3011: Deny further writes after InternalParquetRecordWriter is aborted#3450
Open
LuciferYang wants to merge 1 commit intoapache:masterfrom
Open
GH-3011: Deny further writes after InternalParquetRecordWriter is aborted#3450LuciferYang wants to merge 1 commit intoapache:masterfrom
LuciferYang wants to merge 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
After a write error (e.g. OOM during page flush),
InternalParquetRecordWritersets itsabortedflag to true and re-throws the exception. However, subsequent calls towrite()are silently accepted without checking this flag. Sinceclose()skips flushing whenabortedis true, all data written after the error is silently discarded, producing a corrupted Parquet file without a footer. Users only discover the corruption when they attempt to read the file later.What changes are included in this PR?
Added an
abortedstate check at the beginning ofwrite(). If the writer has been aborted due to a previous error, anIOExceptionis thrown immediately with a clear error message, preventing further writes to a writer in an undefined state.Are these changes tested?
Yes. Added
testWriteAfterAbortShouldThrowinTestParquetWriterErrorthat verifies:IOExceptionwith the expected messageclose()on an aborted writer completes without throwingAll existing tests in
parquet-hadooppass without modification.Are there any user-facing changes?
Yes. Users who previously caught write exceptions and continued writing to the same
ParquetWriterwill now receive anIOExceptionon subsequent write attempts. This is an intentional change to prevent silent data loss — the correct behavior after a write failure is to discard the writer and create a new one.Closes #3011