implementation level refactoring #166
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract method refactoring
Class: org.apache.pdfbox.io.ScratchFile
Reason for refactoring: Complex method - Cyclomatic complexity of enlarge() method is 9.
Explanation of refactoring: Method is divided into multiple methods to reduce the cyclomatic complexity.
Decompose conditional refactoring
Class: org.apache.pdfbox.io.MemoryUsageSetting
Reason for refactoring: Complex Conditional - The conditional expression locUseMainMemory && (locMaxStorageBytes > -1) && ((locMaxMainMemoryBytes == -1) || (locMaxMainMemoryBytes > locMaxStorageBytes)) is complex.
Explanation of refactoring: Introduced new methods for conditional logic.
Introduce explaining variable refactoring
Class: org.apache.pdfbox.io.IOUtils
Reason for refactoring: Long Statement
Explanation of refactoring: Complicated expressions are replaced by explaining variables.