Skip to content

update some JavaDoc#181

Closed
DvonHolten wants to merge 207 commits intoapache:trunkfrom
DvonHolten:DvH-24-Feb-05
Closed

update some JavaDoc#181
DvonHolten wants to merge 207 commits intoapache:trunkfrom
DvonHolten:DvH-24-Feb-05

Conversation

@DvonHolten
Copy link
Copy Markdown

  • update JavaDoc for class to show if this table is required in a TrueType-font.
  • strip trailing blanks

1.) i see some inconsistencies wrt short/int. The read() method reads the fields as short/int as required, but some classes just convert it to int, whereas other classes keep the 'short'-type, even in getters. What to do?
2.) the read() methods set the initialized-flag when successfully finished. However, this is sticky. When there is a chance, that objects of these xxxTable-classes are reused, the initialized flag should be cleared at method-entry and set at method-end. What to do?

lehmi and others added 30 commits August 14, 2023 15:40
THausherr and others added 25 commits January 8, 2024 04:25
…plementation of pdf.js as proposed by Mike Li on dev@

git-svn-id: https://svn.apache.org/repos/asf/pdfbox/branches/3.0@1915352 13f79535-47bb-0310-9956-ffa450edef68
…something, as suggested by Axel Howind

git-svn-id: https://svn.apache.org/repos/asf/pdfbox/branches/3.0@1915561 13f79535-47bb-0310-9956-ffa450edef68
…eType-font.

- strip trailing blanks

1.) i see some inconsistencies wrt short/int. The read() method reads the fields as short/int as required, but some classes just convert it to int, whereas other classes keep the 'short'-type, even in getters. What to do?
2.) the read() methods set the initialized-flag when successfully finished. However, this is sticky. When there is a chance, that objects of these xxxTable-classes are reused, the initialized flag should be cleared at method-entry and set at method-end. What to do?
@THausherr
Copy link
Copy Markdown
Contributor

Something went wrong here, this PR has 207 commits, but not by you?!

@DvonHolten
Copy link
Copy Markdown
Author

tja...
i try again - shall the pullrequests go to the trunk or to some branch?

@THausherr
Copy link
Copy Markdown
Contributor

Always against the trunk

@DvonHolten DvonHolten closed this Feb 5, 2024
@DvonHolten DvonHolten deleted the DvH-24-Feb-05 branch February 5, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants