Skip to content

share trailers through matval#303

Closed
laglangyue wants to merge 3 commits intoapache:mainfrom
laglangyue:FIXME-share-trailers-through-matval
Closed

share trailers through matval#303
laglangyue wants to merge 3 commits intoapache:mainfrom
laglangyue:FIXME-share-trailers-through-matval

Conversation

@laglangyue
Copy link
Contributor

@laglangyue laglangyue commented Apr 17, 2024

motivation

close #302
share trailers through matval

how

  • remove usage of val trailerPromise = Promise[Metadata]()
  • use pekko metadata instead of grpc-java metadata
  • will throw class GrpcServiceException(val status: Status, val metadata: Metadata) extends StatusRuntimeException(status, metadata.raw.orNull) instead of StatusRuntimeException (grpc-java)

@Roiocam
Copy link
Member

Roiocam commented Apr 17, 2024

It seems that you missed the deletion of FIXME comment.

@laglangyue laglangyue changed the title resolve FIXME share trailers through matval share trailers through matval Apr 17, 2024
@laglangyue
Copy link
Contributor Author

It seems that you missed the deletion of FIXME comment.

you mean it in title and description? I have removed it.

@Roiocam
Copy link
Member

Roiocam commented Apr 17, 2024

you mean it in title and description? I have removed it.

In the code mentioned in your ISSUE

def onCallClosed(status: Status, trailers: Metadata): Unit = {
if (status.isOk()) {
// FIXME share trailers through matval
completeStage()
} else {
failStage(status.asRuntimeException(trailers))
}
call = null

@laglangyue laglangyue marked this pull request as draft April 17, 2024 11:52
@laglangyue laglangyue closed this Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

try to resolve FIXME share trailers through matval

2 participants