make Content-Type and Content-Length constructors accessible in pekko packages#178
Merged
pjfanning merged 1 commit intoapache:mainfrom Jun 11, 2023
Merged
Conversation
… packages Pekko-Connectors S3 uses these constructors
Contributor
|
They are private because they must only be used internally. AFAICS there's no good reason to use the headers in the S3 connector in that way, in any case, it's not related to the module's use of pekko-http, and there the HTTP headers are just used for convenience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pekko-Connectors S3 uses these constructors.
See apache/pekko-connectors#167
Scala 3 is stricter about private and package private access.