test: replace Await.result with futureValue in MethodDirectivesSpec#979
Merged
He-Pin merged 1 commit intoapache:mainfrom Mar 8, 2026
Merged
Conversation
Port akka-http commit b85460691 by replacing a brittle 100 ms Await.result timeout with futureValue in MethodDirectivesSpec. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
|
Can you link the actual commit or PR? So it can be reviewed if the change is part of a release that we are allowed to take fixes from. |
Member
|
This looks like akka/akka-http#4211 which is now Apache licensed - see #960 |
Member
Author
|
I checked the commit, it's ok. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
A
CONNECTmethod directive test usedAwait.result(f, 100.millis)— a 100 ms hard timeout that can fail immediately on overloaded CI machines or slow developer workstations where the future hasn't resolved within that window. The upstream akka-http fix (commitb85460691) replaced the Await call with ScalaTest'sfutureValue.Modification
Replace
Await.result(…, 100.millis)withfutureValueinMethodDirectivesSpec, which honors the configuredPatienceConfigtimeout (default 5 s) and retries automatically. Remove now-unusedAwaitandFutureimports.Ported from akka-http commit:
b85460691Result
Test no longer flakes on loaded CI or slow machines due to an artificially tight 100 ms timeout.