Add hash suffix on truncation for Kubernetes lease names (#708)#723
Merged
pjfanning merged 1 commit intoapache:1.3.xfrom Mar 28, 2026
Merged
Add hash suffix on truncation for Kubernetes lease names (#708)#723pjfanning merged 1 commit intoapache:1.3.xfrom
pjfanning merged 1 commit intoapache:1.3.xfrom
Conversation
* Initial plan * Add on-truncate-add-hash-length config with SHA-256/base32 hash suffix on truncation Co-authored-by: pjfanning <11783444+pjfanning@users.noreply.github.com> * Add Base32EncodeSpec with edge-case tests; widen base32Encode to private[kubernetes] Co-authored-by: pjfanning <11783444+pjfanning@users.noreply.github.com> * Switch hash suffix to take first N chars; add tests for names differing by last 1-2 chars Co-authored-by: pjfanning <11783444+pjfanning@users.noreply.github.com> * Handle hashLength >= maxLength gracefully; fix test bugs and add edge-case tests Co-authored-by: pjfanning <11783444+pjfanning@users.noreply.github.com> * scalafmt * Refactor string concatenation to use string interpolation * Update Base32EncodeSpec.scala * Update Base32EncodeSpec.scala * update long hash len logic * Update MakeDNS1039CompatibleSpec.scala --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: pjfanning <11783444+pjfanning@users.noreply.github.com>
Member
Author
|
the CI build failure is not related to this change and is dealt with in #729 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry pick e133bfe #702 #708