Port akka-core#31753: Run DurableStateBehavior delete effect asynchronously like persist#2752
Merged
pjfanning merged 2 commits intoapache:mainfrom Mar 19, 2026
Merged
Conversation
… way as persist Co-authored-by: pjfanning <11783444+pjfanning@users.noreply.github.com>
He-Pin
reviewed
Mar 18, 2026
| .debug("Received DeleteSuccess response after: {} nanos", System.nanoTime() - persistStartTime) | ||
| } | ||
|
|
||
| // TODO Might need to call hook method for Telemetry |
Member
Author
There was a problem hiding this comment.
Can't any harm keeping it. It is from the Akka PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleteeffects inDurableStateBehaviorwere applied synchronously — side effects (thenRun,thenReply) fired immediately without waiting for the store to confirm the delete. This broke command ordering: commands queued after a delete could be processed before the delete completed.akka/akka-core#31753
part of #2730
Changes
Running.scala: AddedhandleDeleteinHandlingCommandsthat transitions toPersistingState(mirroringhandlePersist). AddedonDeleteSuccess/onDeleteFailedhandlers toPersistingState.DeleteSuccess/DeleteFailuremessages were previouslyBehaviors.unhandled.DurableStateStoreInteractions.scala: RemovedonDeleteInitiatedhook (unused telemetry stub). Annotatedcmdparameter as@nowarnunused.DurableStateBehaviorReplySpec.scala: Renamed test suite; added"handle commands sequentially"test covering mixed increment + delete ordering.DurableStateBehaviorSpec.scala(new): Basic tests for persist, delete, and sequential command handling onDurableStateBehavior.