Disable ClusterShardingHealthCheck after configured duration post member-up#2785
Merged
pjfanning merged 4 commits intoapache:mainfrom Mar 24, 2026
Merged
Conversation
…uration when member is up Co-authored-by: pjfanning <11783444+pjfanning@users.noreply.github.com> Agent-Logs-Url: https://github.com/pjfanning/incubator-pekko/sessions/bc72a2b0-c6d6-4bc2-983d-5d488ff934f4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #2730
akka/akka-core#31864
ClusterShardingHealthCheckwould fail indefinitely if a new entity type added in a rolling update hadn't registered with the coordinator yet, stalling the rollout. The fix disables the health check (returnstrue) after a configurable duration once the cluster member isUp.Changes
ClusterShardingHealthCheckSettings: AddeddisableAfter: FiniteDurationparameter; deprecated 2-arg constructor kept for binary compatibilityClusterShardingHealthCheck: TracksstartedTimestampwhen member first becomesUp; bypasses shard region checks oncedisabled-afterhas elapsedreference.conf: Newdisabled-after = 10sunderpekko.cluster.sharding.healthcheck"always pass after disabled-after"test using a real cluster provider to verify the clock only starts post-MemberStatus.UpBehaviour
Clock starts only after
selfMember.statusleavesJoining/Removed. Checks before that are unaffected. Once the deadline is exceeded, the check short-circuits totruewithout contacting the shard region.