Update GroupBy doc: use idiomatic groupBy key function#2795
Merged
He-Pin merged 1 commit intoapache:mainfrom Mar 28, 2026
Merged
Update GroupBy doc: use idiomatic groupBy key function#2795He-Pin merged 1 commit intoapache:mainfrom
He-Pin merged 1 commit intoapache:mainfrom
Conversation
Change groupBy key from '_ % 2 == 0' (Boolean) to '_ % 2' (Int) for a more idiomatic example. Add note about non-deterministic mergeSubstreams output ordering. Upstream: akka/akka-core@1ed6dc09fd Cherry-picked from akka/akka-core v2.8.0, which is now Apache licensed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Philippus
requested changes
Mar 28, 2026
Member
Philippus
left a comment
Philippus
left a comment
There was a problem hiding this comment.
Can we also change the corresponding Java example? That would make comparing code examples less confusing.
Member
Author
|
@Philippus, please unlock this. You can submit a pr to follow up, my local agents are in another loop |
Philippus
approved these changes
Mar 28, 2026
Member
Author
|
@Philippus, because my local harness is current in another loop, and each loop costs some money:) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The GroupBy documentation example used a hardcoded number of substreams instead of demonstrating the idiomatic key-based grouping pattern.
Modification
Updated the GroupBy documentation to use a proper key function that groups elements by their inherent property, making the example more realistic and educational.
Result
Documentation now shows the recommended way to use GroupBy with a meaningful key function.
References