Improve DData remember entities logging and consistency#2799
Merged
He-Pin merged 1 commit intoapache:mainfrom Mar 28, 2026
Merged
Improve DData remember entities logging and consistency#2799He-Pin merged 1 commit intoapache:mainfrom
He-Pin merged 1 commit intoapache:mainfrom
Conversation
Multiple improvements to DData remember entities stores: - DDataRememberEntitiesShardStore: Retry reads up to 15 times (across all 5 keys) before giving up, logging at warning level initially and escalating to error only on final failure. Previously failed immediately on first GetFailure. - DDataRememberEntitiesCoordinatorStore: Already retried indefinitely, but now waits until 5 failures before escalating from warning to error level logging. - All log messages now clearly indicate whether they originate from the coordinator store or shard store (prefix: 'Remember entities coordinator/shard store'). - Change consistency levels from ReadMajority/WriteMajority to ReadMajorityPlus/WriteMajorityPlus, using coordinatorStateReadMajorityPlus and coordinatorStateWriteMajorityPlus settings, with ReadAll/WriteAll fallback when configured as Int.MaxValue. Upstream: akka/akka-core@440fdfdcc2 Cherry-picked from akka/akka-core v2.8.0, which is now Apache licensed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
|
The PR description is a bit off, this change does more than change the logging, it also adds retries. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
DData remember entities logging was inconsistent and some important state transitions were logged at wrong levels.
Modification
Improved logging for DData remember entities operations to use appropriate log levels and include relevant context information.
Result
Better observability for distributed data remember entities operations.
References