Fix EventSourcedBehaviorStashSpec flaky failures#2804
Merged
He-Pin merged 1 commit intoapache:mainfrom Mar 28, 2026
Merged
Conversation
Multiple fixes for test flakiness: - Increase timeout from 5s to 10s for concurrent stash operations that produce many events, giving the system enough time under load. - Change StashLimit.customStashLimit from val to def for proper trait initialization order. - Add thenRun callback to 'start-stashing' persist to confirm write completion before sending more commands, preventing race conditions where commands are auto-stashed by ESB instead of user stash. - Wait for 'started-stashing' confirmation in both stash limit tests before flooding with commands. Upstream: akka/akka-core@1c9b1b4116 Cherry-picked from akka/akka-core v2.8.0, which is now Apache licensed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Philippus
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
EventSourcedBehaviorStashSpec had timing-sensitive assertions that could fail under load.
Modification
Increased timeouts and adjusted assertion patterns to handle variable timing in stash processing.
Result
Stash spec is more reliable in CI environments.
References