test(stream-tests): enable virtualized stream dispatcher in JDK 21+ nightly CI#2882
Merged
He-Pin merged 1 commit intoapache:mainfrom Apr 22, 2026
Merged
Conversation
He-Pin
added a commit
to He-Pin/incubator-pekko
that referenced
this pull request
Apr 21, 2026
… and simplify comment
Motivation:
Long explanatory comments in reference.conf were too verbose and the virtualize setting should live in application.conf on the test classpath to be clearer and easier to override in CI.
Modification:
- Remove verbose comment and virtualize lines from reference.conf
- Add stream-testkit/src/test/resources/application.conf with default virtualize = off and optional env override ${?PEKKO_VIRTUALIZE_DISPATCHER}
Result:
- Shorter, clearer comment in reference.conf
- Virtual threads controlled via application.conf and PEKKO_VIRTUALIZE_DISPATCHER env var in CI
References: PR apache#2882, Issue apache#2870
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
He-Pin
force-pushed
the
feat-virtualize-dispatcher-v2
branch
from
dc2c091 to
52d249a
Compare
He-Pin
force-pushed
the
feat-virtualize-dispatcher-v2
branch
from
52d249a to
5e42e05
Compare
Motivation: Remove the stream-testkit reference.conf churn so the PR stays focused on the intended nightly virtualize wiring. Modification: Rebuild the branch from origin/main with only the nightly workflow change and the stream-tests application.conf override. Result: The PR diff is reduced to two files with no unrelated testkit comment changes. References: upstream PR apache#2872 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
He-Pin
force-pushed
the
feat-virtualize-dispatcher-v2
branch
from
5e42e05 to
911c067
Compare
He-Pin
changed the title
Member
Author
|
@pjfanning please take a look ~ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
JDK-8300995 can still trigger ForkJoinPool compensation-thread starvation in FIFO mode, which shows up as sporadic stream test timeouts when actors block on reply futures. For JDK 21+ nightly CI we can exercise virtualized fork-join workers instead, while keeping local test defaults unchanged.
Changes
.github/workflows/nightly-builds.ymlnow setsPEKKO_VIRTUALIZE_DISPATCHER=ononly for JDK 21+ nightly jobs.stream-tests/src/test/resources/application.confadds a test-only override forpekko.test.stream-dispatcher.fork-join-executor.virtualize, defaulting tooffand reading the env var when present.Result
virtualize = off.Related