test: shut down cluster test systems in reverse order#2997
Merged
Conversation
Motivation: MixedProtocolClusterSpec nightly runs can pass their cluster join assertions but still fail when shutdownAll stops the first seed ActorSystem before the joining nodes have left. On JDK 25 virtualized dispatcher runs this can leave remoting shutdown waiting until the actor-system-terminate phase times out. Modification: Shut down ClusterTestKit actor systems in reverse registration order so joining nodes leave first while the seed is still available. Result: Multi-ActorSystem cluster specs using shutdownAll keep the seed alive until the dependent nodes have terminated, reducing shutdown timeout flakiness without reducing test coverage. Tests: - JDK 25 nightly-style: sbt "cluster / Test / testOnly org.apache.pekko.cluster.MixedProtocolClusterSpec" - 9 tests succeeded / 0 failed - scalafmt --mode diff-ref=origin/main - scalafmt --list --mode diff-ref=origin/main - git diff --check References: None - nightly-builds.yml MixedProtocolClusterSpec shutdown timeout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
MixedProtocolClusterSpec nightly runs can pass their cluster join assertions but still fail in shutdownAll when the first seed ActorSystem is stopped before the joining nodes have left. On JDK 25 virtualized dispatcher runs this can leave remoting shutdown waiting until the actor-system-terminate phase times out.
Modification
Shut down ClusterTestKit actor systems in reverse registration order so joining nodes leave first while the seed is still available.
Result
Multi-ActorSystem cluster specs using shutdownAll keep the seed alive until dependent nodes have terminated, reducing shutdown timeout flakiness without reducing test coverage or weakening assertions.
Tests
sbt "cluster / Test / testOnly org.apache.pekko.cluster.MixedProtocolClusterSpec"- 9 tests succeeded / 0 failedscalafmt --mode diff-ref=origin/mainscalafmt --list --mode diff-ref=origin/maingit diff --checkReferences
None - nightly-builds.yml MixedProtocolClusterSpec shutdown timeout