Fix sbt load warnings by excluding unused lint keys#3029
Merged
Conversation
Motivation: sbt load was showing 165 warnings about unused keys, which cluttered the output and made it harder to identify real issues. Modification: Added Global / excludeLintKeys to build.sbt to exclude the following keys from lintUnused checks: - projectInfoVersion (used for linking to API docs) - logManager (used to add timestamps to log output) - unidocProjectFilter (used to filter projects for unidoc generation) - fork (used for PR validation) - javacOptions (used to disable doclint for tests) Result: sbt load now completes without any warnings about unused keys. Tests: - Verified sbt load completes without warnings Refs: None - housekeeping
Member
Author
|
@pjfanning I will backport this to 1.7.x |
Member
|
@He-Pin why do we need this in 1.x? It is useful in main branch but 1.x branches are not very active and used for occasional patches. |
Member
Author
|
Because I don't want to see the warning @pjfanning |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
sbt load was showing 165 warnings about unused keys, which cluttered the output and made it harder to identify real issues.
Modification
Added to to exclude the following keys from checks:
Result
sbt load now completes without any warnings about unused keys.
Tests
References
None - housekeeping