Skip to content

Conversation

@richardantal
Copy link
Contributor

Change-Id: I7663d7b86481e90d783081440637fe5aade5d221

Change-Id: I7663d7b86481e90d783081440637fe5aade5d221
@stoty
Copy link
Contributor

stoty commented May 10, 2021

+1 LGTM
Thank you

@stoty
Copy link
Contributor

stoty commented May 10, 2021

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 30s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 28m 25s master passed
+1 💚 compile 0m 27s master passed
+1 💚 javadoc 0m 11s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 17m 38s the patch passed
+1 💚 compile 0m 27s the patch passed
+1 💚 javac 0m 27s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 2s The patch has no ill-formed XML file.
+1 💚 javadoc 0m 11s the patch passed
_ Other Tests _
+1 💚 unit 3m 33s phoenix5-spark-shaded in the patch passed.
-1 ❌ asflicense 0m 9s The patch generated 1 ASF License warnings.
51m 54s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-52/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #52
Optional Tests dupname asflicense javac javadoc unit xml compile
uname Linux 919eb5841ae9 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-connectors-personality.sh
git revision master / 0583b22
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-52/1/testReport/
asflicense https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-52/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count 93 (vs. ulimit of 30000)
modules C: phoenix-spark-base/phoenix5-spark-shaded U: phoenix-spark-base/phoenix5-spark-shaded
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-52/1/console
versions git=2.7.4 maven=3.3.9
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@richardantal richardantal merged commit eaf5adf into apache:master May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants